LLO Transmit Client Metric Fix #20520
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-security-plaid-production
bot
requested a review
from cedric-cordenier
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the LLO transmit client metrics logic where the transmit duration metric was only being recorded for failed transmissions instead of successful ones.
Key Changes:
- Corrected conditional logic in
client.goto record metrics on successful transmits (err == nil) instead of failed ones (err != nil)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
core/services/llo/grpc/client.go |
Fixed the error check condition from err != nil to err == nil to record metrics on successful transmits |
.changeset/silver-moles-type.md |
Added changeset documenting the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
brunotm
previously approved these changes
Dec 4, 2025
|
brunotm
approved these changes
Dec 4, 2025
jmank88
approved these changes
Dec 4, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
* observe client transmit latency on successful Transmit calls * update changeset * Update silver-moles-type.md
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.