Tasks block until TaskMinConfirmations have been met #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitri Roche <dimroc@gmail.com>
Signed-off-by: Steve Ellis <email@steveell.is>
Signed-off-by: Dimitri Roche <dimroc@gmail.com>
Signed-off-by: Steve Ellis <email@steveell.is>
Signed-off-by: Dimitri Roche <dimroc@gmail.com>
dimroc
changed the title
Eventually, gock will be removed entirely.
dimroc
force-pushed
the
features/task-confirmations
branch
from
f82c37a to
ced632f
Compare
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 83.68% 83.82% +0.13%
==========================================
Files 39 39
Lines 2869 2955 +86
==========================================
+ Hits 2401 2477 +76
- Misses 296 307 +11
+ Partials 172 171 -1
Continue to review full report at Codecov.
|
dimroc
changed the title
|
Maybe we should have TASK_MIN_CONFIRMATIONS default to 0 until we're done with the epic. |
se3000
approved these changes
Mar 23, 2018
| }{ | ||
| {"unset", nil, big.NewInt(2), big.NewInt(2)}, | ||
| {"set", big.NewInt(1), big.NewInt(2), big.NewInt(1)}, | ||
| {"unset and nil", nil, nil, nil}, |
| run.Status = models.StatusErrored | ||
| run.Result.SetError(err) | ||
| return run | ||
| if !jr.Runnable(bn, store.Config.TaskMinConfirmations) { |
There was a problem hiding this comment.
Good call on putting this check in here. Looking easy to update in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the renaming and addition of the following configurations: