Skip to content

fix: add selectors for solana to include solana tx on proposal #17552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2025
Merged

fix: add selectors for solana to include solana tx on proposal #17552

merged 2 commits into from
May 2, 2025
+19 −2

Conversation

ecPablo
Copy link
Contributor

@ecPablo ecPablo commented May 1, 2025

Add solana chain selectors when the config is empty.

@ecPablo ecPablo requested review from a team as code owners May 1, 2025 22:26
gustavogama-cll
gustavogama-cll previously approved these changes May 1, 2025
View reviewed changes
@gustavogama-cll gustavogama-cll enabled auto-merge May 1, 2025 22:27
carte7000
carte7000 previously approved these changes May 1, 2025
View reviewed changes
@ecPablo ecPablo dismissed stale reviews from carte7000 and gustavogama-cll via b23c151 May 1, 2025 22:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2025

Flakeguard Summary

Ran new or updated tests between develop and b23c151 (ecpablo/fix-mcms-firedrill).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

6 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestDeployMCMSWithTimelockV2 33.3333% false false true 3 1 2 0 github.com/smartcontractkit/chainlink/deployment/common/changeset false 45.995s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestMCMSSignFireDrillChangeset 66.6667% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/deployment/common/changeset false 53.066666666s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestRenounceTimelockDeployerConfigValidate 66.6667% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/deployment/common/changeset false 2.256666666s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestSetConfigMCMSV2Solana/MCMS_disabled 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/common/changeset false 56.896666666s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestSetConfigMCMSVariants/MCMS_disabled 33.3333% false false false 3 1 2 0 github.com/smartcontractkit/chainlink/deployment/common/changeset false 48.52s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team
TestValidate 0% false false true 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/common/changeset false 48.4s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/core, @smartcontractkit/deployment-automation, @smartcontractkit/cld-team

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@gustavogama-cll gustavogama-cll added this pull request to the merge queue May 1, 2025
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2025
@carte7000 carte7000 added this pull request to the merge queue May 2, 2025
Merged via the queue into develop with commit 21402e1 May 2, 2025
136 of 138 checks passed
@carte7000 carte7000 deleted the ecpablo/fix-mcms-firedrill branch May 2, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carte7000 carte7000 carte7000 approved these changes

@gustavogama-cll gustavogama-cll gustavogama-cll approved these changes

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@matYang matYang Awaiting requested review from matYang matYang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecPablo @carte7000 @gustavogama-cll