Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git-ignore .envrc #168

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Git-ignore .envrc #168

merged 1 commit into from
Mar 15, 2018

Conversation

Empact
Copy link
Contributor

@Empact Empact commented Mar 15, 2018

This file is recommended for development here:
https://github.com/smartcontractkit/chainlink/wiki/Development-Tips#direnv

But its particulars can be system-specific, so we can ignore it in the repo to
avoid improper inclusion.

This file is recommended for development here:
https://github.com/smartcontractkit/chainlink/wiki/Development-Tips#direnv

But its particulars can be system-specific, so we can ignore it in the repo to
avoid improper inclusion.
@codecov
Copy link

codecov bot commented Mar 15, 2018

Codecov Report

Merging #168 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   83.17%   83.13%   -0.05%     
==========================================
  Files          39       39              
  Lines        2312     2312              
==========================================
- Hits         1923     1922       -1     
- Misses        238      239       +1     
  Partials      151      151
Impacted Files Coverage Δ
web/job_runs_controller.go 72.3% <0%> (-3.08%) ⬇️
logger/logger.go 74.28% <0%> (-2.86%) ⬇️
services/subscription.go 80.79% <0%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e1e132...58119ee. Read the comment docs.

@se3000 se3000 merged commit 2a10d41 into master Mar 15, 2018
@Empact Empact deleted the ignore-envrc branch March 16, 2018 00:17
pavel-raykov pushed a commit that referenced this pull request Jun 14, 2024
* Fixing native/link fee calculation

* Inclusing cents_in_usd into the price_scaling_factor to simplify the fee calculation

* CalculateFee returns 0 when token price or base fee is 0

* Using decimal package for fee calculation

* Fixing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants