Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no padding + mcms #16511

Closed
wants to merge 53 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
18238ab
try upgrade in CI
tt-cll Feb 13, 2025
6cca0c8
Merge remote-tracking branch 'origin/develop' into tt/solanaUpgrades
tt-cll Feb 13, 2025
fd07e4a
update sha
tt-cll Feb 13, 2025
2740026
make gomodtidy
tt-cll Feb 13, 2025
750c267
try setting signer
tt-cll Feb 13, 2025
dc7c4b5
fix params
tt-cll Feb 13, 2025
4197aac
set keypair to authority
tt-cll Feb 13, 2025
55de91e
deploy same artifact
tt-cll Feb 13, 2025
21c5043
Merge remote-tracking branch 'origin/develop' into tt/solanaUpgrades
tt-cll Feb 13, 2025
937b0e9
revert gomod
tt-cll Feb 13, 2025
a39034e
return ixns
tt-cll Feb 15, 2025
1b7345e
upgrade in place
tt-cll Feb 15, 2025
9f3550b
Merge remote-tracking branch 'origin/develop' into tt/solanaUpgrades
tt-cll Feb 15, 2025
6953d7a
fix build
tt-cll Feb 15, 2025
c97275e
lint
tt-cll Feb 15, 2025
9f31584
bump gomod
tt-cll Feb 15, 2025
ab47391
validate upgrades
tt-cll Feb 15, 2025
80202c5
lint
tt-cll Feb 15, 2025
8468bb4
comments
tt-cll Feb 17, 2025
c6b2475
Merge remote-tracking branch 'origin/develop' into tt/solanaUpgrades
tt-cll Feb 17, 2025
07866dc
gomod
tt-cll Feb 17, 2025
f27eae6
fix merge
tt-cll Feb 18, 2025
02980fa
lint
tt-cll Feb 18, 2025
a23d140
lint
tt-cll Feb 18, 2025
74f835f
cr comments
tt-cll Feb 18, 2025
ab58af5
lint
tt-cll Feb 18, 2025
514651e
lint
tt-cll Feb 18, 2025
20ab5e4
lint
tt-cll Feb 18, 2025
814a3ba
Merge remote-tracking branch 'origin/develop' into tt/solanaUpgrades
tt-cll Feb 18, 2025
798d06b
move upgrades to mcms
tt-cll Feb 18, 2025
4ac68ab
bump delay
tt-cll Feb 18, 2025
3a32ebc
wip
tt-cll Feb 19, 2025
8ca3f34
wip
tt-cll Feb 19, 2025
5d1cf7b
mcms fix
tt-cll Feb 19, 2025
8f2035f
log in CI
tt-cll Feb 19, 2025
66eea30
preload first
tt-cll Feb 19, 2025
e2261bf
Merge pull request #16465 from smartcontractkit/tt/mcms1
tt-cll Feb 19, 2025
639eb8d
Merge remote-tracking branch 'origin/develop' into tt/solanaUpgrades
tt-cll Feb 19, 2025
93d29b3
wip
tt-cll Feb 20, 2025
ecc46ff
wip
tt-cll Feb 20, 2025
de3ae32
check bytes
tt-cll Feb 20, 2025
74d17e5
lint
tt-cll Feb 20, 2025
fabd20b
revert buffer
tt-cll Feb 20, 2025
b8cef56
Merge pull request #16493 from smartcontractkit/tt/extend
tt-cll Feb 21, 2025
2691c6b
Merge remote-tracking branch 'origin/develop' into tt/solanaUpgrades
tt-cll Feb 21, 2025
7e500ae
use program data size
tt-cll Feb 21, 2025
3a73a76
add padding
tt-cll Feb 21, 2025
077f354
no padding + mcms
tt-cll Feb 21, 2025
9a80c3c
no padding + mcms
tt-cll Feb 21, 2025
09bafb2
lint
tt-cll Feb 21, 2025
abdbce8
Merge branch 'tt/solanaUpgrades' into tt/shouldBreakMcms
tt-cll Feb 21, 2025
334689d
bubble mcms error
tt-cll Feb 21, 2025
6df6280
Merge remote-tracking branch 'origin/tt/solanaUpgrades' into tt/shoul…
tt-cll Feb 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add padding
  • Loading branch information
tt-cll committed Feb 21, 2025
commit 3a73a765a70469bda18893d3bc09c0468ab36686
2 changes: 1 addition & 1 deletion deployment/ccip/changeset/solana/cs_deploy_chain.go
Original file line number Diff line number Diff line change
Expand Up @@ -906,7 +906,7 @@ func generateExtendIxn(
//https://github.com/solana-labs/solana/blob/7700cb3128c1f19820de67b81aa45d18f73d2ac0/sdk/program/src/loader_upgradeable_instruction.rs#L146
data := binary.LittleEndian.AppendUint32([]byte{}, 6) // 4-byte Extend instruction identifier
//nolint:gosec // G115 we check for overflow above
data = binary.LittleEndian.AppendUint32(data, uint32(extraBytes))
data = binary.LittleEndian.AppendUint32(data, uint32(extraBytes + 1024)) // add some padding

keys := solana.AccountMetaSlice{
solana.NewAccountMeta(programDataAccount, true, false), // Program data account (writable)
Expand Down
Loading