Add Monad Testnet Config and Error Mapping #15993
Conversation
ccip/config/evm/Monad_Testnet.toml
Outdated
| @@ -0,0 +1,23 @@ | |||
| ChainID = '10143' | |||
| # finality_depth was: 0 | |||
| FinalityDepth = 10 | |||
There was a problem hiding this comment.
did the finality committee approve the number?
There was a problem hiding this comment.
I haven't reached out, was going off a previous conversation I had with @fernandezlautaro regarding finality where a chain with instant finality we default to using a finality depth of 10 (example being sei). Please let me know if I should
There was a problem hiding this comment.
Yes please atleast make them aware, Max would be a good person to start with
There was a problem hiding this comment.
I think if we dont have the DF. we dont need to override all the configs inside core, do we?
There was a problem hiding this comment.
Seems like we always need to have this override. CCIP's is the option one.
There was a problem hiding this comment.
yea but shouldn't the chainID only be enough & the rest will be picked up from the ccip defaults?
There was a problem hiding this comment.
Yes, this should work. But it's better to verify with a test
ccip/config/evm/Monad_Testnet.toml
Outdated
| LogBroadcasterEnabled = false | ||
| FinalityTagEnabled = false | ||
| # finality_depth * block_time / 60 secs = < 1 min (finality time) | ||
| NoNewFinalizedHeadsThreshold = '1m' |
There was a problem hiding this comment.
nit: Should we also set NoNewHeadsThreshold to a lower value (current 3m)?
|
Sry for the re-approval. got word back from Max and was advised to bump up finality depth @simsonraj @dhaidashenko |
|
No description provided.