add dry option; return useful config #15314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolekk
reviewed
Nov 19, 2024
deployment/keystone/deploy.go
Outdated
| if cfg.DryRun { | ||
| prefix = "DRY RUN: " | ||
| } | ||
| env.Logger.Infof("%sconfiguring OCR3 contract for chain %d", cfg.ChainSel, prefix) |
deployment/keystone/deploy.go
Outdated
| prefix = "DRY RUN: " | ||
| } | ||
| env.Logger.Infof("%sconfiguring OCR3 contract for chain %d", cfg.ChainSel, prefix) | ||
| //func ConfigureOCR3ContractFromJD(env *deployment.Environment, chainSel uint64, nodeIDs []string, addrBook deployment.AddressBook, cfg *OracleConfigWithSecrets) (*ConfigureOCR3Resp, error) { |
patrickhuie19
previously approved these changes
Nov 19, 2024
krehermann
force-pushed
the
ks/cfg-ocr-dry-run
branch
from
78578d1 to
333ca16
Compare
|
I see you updated files related to
|
bolekk
approved these changes
Nov 19, 2024
jmank88
approved these changes
Nov 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
cedric-cordenier
pushed a commit
that referenced
this pull request
Nov 20, 2024
* add dry option; return useful config * dry run logging * cleanup * rename * fix broken refs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows us to dry run and get useful configuration of ocr3 contract changes
Requires
Supports