Enable add chain test #14904
Merged
Enable add chain test #14904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing function from DestConfig
All destChain configs have same Router address which is the same as the chainSel. We just need to call with a different destChainSelector
Add missing function from DestConfig Debugging Fix OnRamp.GetDestChainConfig All destChain configs have same Router address which is the same as the chainSel. We just need to call with a different destChainSelector Cleaning Clean contract configs Clean contract configs Add Gas Price test in initial_deploy_test.go Bump chainlink-ccip Bump chainlink-ccip cleaning cmoments linting skip failing test for now unskip
asoliman92
previously approved these changes
Oct 23, 2024
b-gopalswami
previously approved these changes
Oct 23, 2024
connorwstein
previously approved these changes
Oct 23, 2024
Tofel
previously approved these changes
Oct 23, 2024
erikburt
previously approved these changes
Oct 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
AnieeG
dismissed stale reviews from erikburt, Tofel, connorwstein, b-gopalswami, and asoliman92
via
bd58ad7
AER Report: CI Core ran successfully ✅ |
0xAustinWang
approved these changes
Oct 24, 2024
erikburt
approved these changes
Oct 24, 2024
|
asoliman92
approved these changes
Oct 24, 2024
cedric-cordenier
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Add FeeQuoter to SourceConfig Add missing function from DestConfig * cl-ccip bump * Debugging * Fix OnRamp.GetDestChainConfig All destChain configs have same Router address which is the same as the chainSel. We just need to call with a different destChainSelector * Cleaning * Clean contract configs * Clean contract configs * Add Gas Price test in initial_deploy_test.go * Bump chainlink-ccip * Bump chainlink-ccip * cleaning cmoments * linting * skip failing test for now * unskip * Add FeeQuoter to SourceConfig Add missing function from DestConfig Debugging Fix OnRamp.GetDestChainConfig All destChain configs have same Router address which is the same as the chainSel. We just need to call with a different destChainSelector Cleaning Clean contract configs Clean contract configs Add Gas Price test in initial_deploy_test.go Bump chainlink-ccip Bump chainlink-ccip cleaning cmoments linting skip failing test for now unskip * Bump chainlink-ccip * Add weth feed * Remove deprecated thing. * Add assertions for weth * Remove replacement. * linting * gomodtidy * Make TestAddChainInbound test Bidirectional and rename to TestAddChain * updates * changes * more changes * updates * go mod update * more fix * fix lint * fix lint * go mod --------- Co-authored-by: asoliman <abdelrahman.soliman@smartcontract.com> Co-authored-by: Will Winder <wwinder.unh@gmail.com>
KMontag42
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Add FeeQuoter to SourceConfig Add missing function from DestConfig * cl-ccip bump * Debugging * Fix OnRamp.GetDestChainConfig All destChain configs have same Router address which is the same as the chainSel. We just need to call with a different destChainSelector * Cleaning * Clean contract configs * Clean contract configs * Add Gas Price test in initial_deploy_test.go * Bump chainlink-ccip * Bump chainlink-ccip * cleaning cmoments * linting * skip failing test for now * unskip * Add FeeQuoter to SourceConfig Add missing function from DestConfig Debugging Fix OnRamp.GetDestChainConfig All destChain configs have same Router address which is the same as the chainSel. We just need to call with a different destChainSelector Cleaning Clean contract configs Clean contract configs Add Gas Price test in initial_deploy_test.go Bump chainlink-ccip Bump chainlink-ccip cleaning cmoments linting skip failing test for now unskip * Bump chainlink-ccip * Add weth feed * Remove deprecated thing. * Add assertions for weth * Remove replacement. * linting * gomodtidy * Make TestAddChainInbound test Bidirectional and rename to TestAddChain * updates * changes * more changes * updates * go mod update * more fix * fix lint * fix lint * go mod --------- Co-authored-by: asoliman <abdelrahman.soliman@smartcontract.com> Co-authored-by: Will Winder <wwinder.unh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.