Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/internal/features/ocr2: parallelize subtests #14754

Merged
merged 1 commit into from
Dec 18, 2024
Merged

core/internal/features/ocr2: parallelize subtests #14754

merged 1 commit into from
Dec 18, 2024

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Oct 14, 2024 •
edited
Loading

Parallelize sub-tests and bump timeouts.

@jmank88 jmank88 force-pushed the ocr2-features-test-par branch from a5ea373 to f9ff45c Compare October 14, 2024 13:10
@jmank88 jmank88 marked this pull request as ready for review October 14, 2024 13:30
@jmank88 jmank88 requested a review from a team as a code owner October 14, 2024 13:30
@jmank88 jmank88 enabled auto-merge October 14, 2024 13:31
ilija42
ilija42 previously approved these changes Oct 14, 2024
View reviewed changes
@jmank88 jmank88 added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@jmank88 jmank88 dismissed stale reviews from ilija42 and graham-chainlink via 0b0840c October 14, 2024 16:00
@jmank88 jmank88 force-pushed the ocr2-features-test-par branch from f9ff45c to 0b0840c Compare October 14, 2024 16:00
@jmank88 jmank88 requested a review from RensR October 14, 2024 16:05
krehermann
krehermann previously approved these changes Oct 14, 2024
View reviewed changes
@jmank88 jmank88 force-pushed the ocr2-features-test-par branch 2 times, most recently from 1d4216a to 0ea5d37 Compare October 14, 2024 18:03
@jmank88 jmank88 requested review from a team as code owners October 14, 2024 18:03
@jmank88 jmank88 force-pushed the ocr2-features-test-par branch 2 times, most recently from bff0c12 to 4168bea Compare October 14, 2024 18:23
ilija42
ilija42 previously approved these changes Oct 14, 2024
View reviewed changes
@ilija42 ilija42 enabled auto-merge October 14, 2024 21:45
@jmank88 jmank88 requested a review from ilija42 October 14, 2024 22:19
ilija42
ilija42 previously approved these changes Oct 15, 2024
View reviewed changes
@jmank88 jmank88 disabled auto-merge October 15, 2024 16:51
@jmank88 jmank88 marked this pull request as draft October 15, 2024 16:51
@jmank88 jmank88 force-pushed the ocr2-features-test-par branch from 99e2bec to d00dbfc Compare October 15, 2024 17:45
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 15, 2024
@jmank88 jmank88 removed the Stale label Dec 16, 2024
@jmank88 jmank88 force-pushed the ocr2-features-test-par branch from d00dbfc to ba7fa63 Compare December 18, 2024 13:24
@jmank88 jmank88 force-pushed the ocr2-features-test-par branch from ba7fa63 to e32e3fd Compare December 18, 2024 13:24
@jmank88 jmank88 requested a review from erikburt December 18, 2024 13:25
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Dec 18, 2024
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Dec 18, 2024
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Dec 18, 2024
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Dec 18, 2024
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Dec 18, 2024
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@jmank88 jmank88 marked this pull request as ready for review December 18, 2024 14:18
@jmank88 jmank88 requested a review from a team as a code owner December 18, 2024 14:18
@jmank88 jmank88 enabled auto-merge December 18, 2024 14:18
@jmank88 jmank88 added this pull request to the merge queue Dec 18, 2024
Merged via the queue into develop with commit ec35d77 Dec 18, 2024
170 of 171 checks passed
@jmank88 jmank88 deleted the ocr2-features-test-par branch December 18, 2024 15:40
erikburt added a commit that referenced this pull request Dec 20, 2024
@erikburt
Revert "core/internal/features/ocr2: parallelize subtests; extend tim…
29d7785 
…eouts (#14754)"

This reverts commit ec35d77.
@erikburt erikburt mentioned this pull request Dec 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 20, 2024
@erikburt
Revert "core/internal/features/ocr2: parallelize subtests; extend tim…
7314c07 
…eouts (#14754)" (#15792)

This reverts commit ec35d77.
george-dorin pushed a commit that referenced this pull request Jan 13, 2025
@jmank88 @george-dorin
core/internal/features/ocr2: parallelize subtests; extend timeouts (#…
2aa2374 
…14754)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krehermann krehermann krehermann approved these changes

@erikburt erikburt erikburt approved these changes

@graham-chainlink graham-chainlink graham-chainlink left review comments

@ilija42 ilija42 ilija42 left review comments

@reductionista reductionista Awaiting requested review from reductionista reductionista is a code owner automatically assigned from smartcontractkit/foundations

@cedric-cordenier cedric-cordenier Awaiting requested review from cedric-cordenier

@RensR RensR Awaiting requested review from RensR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmank88 @erikburt @krehermann @ilija42 @graham-chainlink