Support RMN in tooling #14682
Merged
Support RMN in tooling #14682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WF: CI Core#e1a7fe2No errors found in this run. 🎉 |
….com:smartcontractkit/chainlink into CCIP-3570-add-support-for-rmn-in-env-tooling
….com:smartcontractkit/chainlink into CCIP-3570-add-support-for-rmn-in-env-tooling
Changes to rpc collect
….com:smartcontractkit/chainlink into CCIP-3570-add-support-for-rmn-in-env-tooling
….com:smartcontractkit/chainlink into CCIP-3570-add-support-for-rmn-in-env-tooling
AnieeG
reviewed
Oct 8, 2024
AnieeG
reviewed
Oct 8, 2024
| "github.com/smartcontractkit/chainlink/v2/core/logger" | ||
| ) | ||
|
|
||
| func TestRMN(t *testing.T) { |
There was a problem hiding this comment.
can we move this to smoke/ccip_test.go ? It will be easier to trigger this in CI
There was a problem hiding this comment.
probably can once its complete. Won't be ready for CI for a while
There was a problem hiding this comment.
So is it unfinished? Or just unable to run in CI? Mind updating the t.Skip() with a more descriptive message?
….com:smartcontractkit/chainlink into CCIP-3570-add-support-for-rmn-in-env-tooling
AnieeG
previously approved these changes
Oct 8, 2024
….com:smartcontractkit/chainlink into CCIP-3570-add-support-for-rmn-in-env-tooling
|
AnieeG
approved these changes
Oct 8, 2024
ogtownsend
approved these changes
Oct 8, 2024
kalverra
requested changes
Oct 9, 2024
| "github.com/smartcontractkit/chainlink/v2/core/logger" | ||
| ) | ||
|
|
||
| func TestRMN(t *testing.T) { |
There was a problem hiding this comment.
So is it unfinished? Or just unable to run in CI? Mind updating the t.Skip() with a more descriptive message?
kalverra
approved these changes
Oct 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new NewLocalDevEnvironmentWithRMN which creates RMN containers in addition to the rest of the environment. TestRMN is a placeholder and can be run locally.