Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ccip-3606 few fixes #14644

Merged
merged 16 commits into from
Oct 3, 2024
Merged

Ccip-3606 few fixes #14644

merged 16 commits into from
Oct 3, 2024

Conversation

AnieeG
Copy link
Contributor

@AnieeG AnieeG commented Oct 2, 2024

Requires

Resolves

@AnieeG AnieeG requested review from a team as code owners October 2, 2024 22:52
@AnieeG AnieeG requested a review from Atrax1 October 2, 2024 22:52
ogtownsend
ogtownsend previously approved these changes Oct 3, 2024
@cl-sonarqube-production
Copy link

}
}

func GenerateNopsView(nodeIds []string, oc deployment.OffchainClient) (NopsView, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can write a test as a follow up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

@AnieeG AnieeG enabled auto-merge October 3, 2024 15:04
@AnieeG AnieeG added this pull request to the merge queue Oct 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2024
@AnieeG AnieeG added this pull request to the merge queue Oct 3, 2024
Merged via the queue into develop with commit 815b2c8 Oct 3, 2024
148 checks passed
@AnieeG AnieeG deleted the ccip-3606-fixes branch October 3, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants