[BCI-3991] - Remove CR from relayer struct #14146
Conversation
| @@ -132,7 +129,7 @@ func (p *mercuryProvider) MercuryServerFetcher() mercurytypes.ServerFetcher { | |||
| } | |||
|
|
|||
| func (p *mercuryProvider) ChainReader() commontypes.ContractReader { | |||
| return p.chainReader | |||
| return nil | |||
There was a problem hiding this comment.
Should this panic? Or better, remove the ChainReader function from the provider interface? Returning nil might cause confusion or errors downstream where a reader is expected and no nil checks are done.
There was a problem hiding this comment.
This method override is coming from the PluginProvider it can't be removed, all other product providers just return nil
| @@ -281,7 +280,6 @@ func (r *Relayer) NewPluginProvider(rargs commontypes.RelayArgs, pargs commontyp | |||
| } | |||
|
|
|||
| return NewPluginProvider( | |||
| r.chainReader, | |||
There was a problem hiding this comment.
We have to update the (r *Relayer) NewPluginProvider() method to initalise Contract Reader from relayArgs. Wrong assumption was made that the ChainReader would be initialised in the relayer body so they tried to use that to initialise PluginProvider
There was a problem hiding this comment.
@ilija42 this is what you mean? 0e9a5b0 (#14146)
Do I need to bind a contract in the initialization?
There was a problem hiding this comment.
@ilija42 this is what you mean? 0e9a5b0 (#14146)
Yes, looks good!
Do I need to bind a contract in the initialization?
No, I just wanted to avoid unexpected behaviour here
There was a problem hiding this comment.
tagging @DeividasK since he worked on PluginProvider
There was a problem hiding this comment.
Message from @DeividasK
👋 hey, we only use relayer.NewContractReader in core/services/relay/evm/write_target.go, so it should be ok to remove the chainReader field.
|
Task Description:
Chain Reader shouldn’t be part of the Relayer struct since it will never have a global config.
This PR:
chainReaderfrom Relayer structureNewPluginProviderandNewMercuryProviderso they don't receive unusedchainReaderanymoreChainReader()method return nilTicket:
Notes: