Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable jpfc cache by default #12966

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Enable jpfc cache by default #12966

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73d05c6
Draft
george-dorin Apr 25, 2024
d76ffa7
Check JuelsPerFeeCoinCache before checking Disable param
george-dorin Apr 25, 2024
859e717
Add test
george-dorin Apr 25, 2024
cd52363
Update NewInMemoryDataSourceCache
george-dorin Apr 25, 2024
a8f7fce
Update NewInMemoryDataSourceCache
george-dorin Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Draft
  • Loading branch information
@george-dorin
george-dorin committed Apr 25, 2024
commit 73d05c63a6a233a86536df5dc557f40b7139da41
1 change: 1 addition & 0 deletions core/services/ocr2/plugins/median/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ type PluginConfig struct {
}

type JuelsPerFeeCoinCache struct {
Disable bool `json:"disable"`
UpdateInterval models.Interval `json:"updateInterval"`
StalenessAlertThreshold models.Interval `json:"stalenessAlertThreshold"`
}
Expand Down
2 changes: 1 addition & 1 deletion core/services/ocr2/plugins/median/services.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func NewMedianServices(ctx context.Context,
CreatedAt: time.Now(),
}, lggr)

if pluginConfig.JuelsPerFeeCoinCache != nil {
if pluginConfig.JuelsPerFeeCoinCache == nil || !pluginConfig.JuelsPerFeeCoinCache.Disable {
lggr.Infof("juelsPerFeeCoin data source caching is enabled")
juelsPerFeeCoinSourceCache, err2 := ocrcommon.NewInMemoryDataSourceCache(juelsPerFeeCoinSource, kvStore, *pluginConfig.JuelsPerFeeCoinCache)
if err2 != nil {
Expand Down
Loading