Skip to content

core/services/relay/evm/mercury: switch to sqlutil.DataSource #12818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2024
Merged

core/services/relay/evm/mercury: switch to sqlutil.DataSource #12818

merged 1 commit into from
Apr 17, 2024

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Apr 15, 2024

@jmank88 jmank88 mentioned this pull request Apr 15, 2024
Merged
1 task
@jmank88 jmank88 force-pushed the BCF-2978-rm-qopts-mercury branch from ceba9a2 to 43665d5 Compare April 15, 2024 14:41
@jmank88 jmank88 force-pushed the BCF-2978-rm-qopts-mercury branch from 43665d5 to 126cd05 Compare April 16, 2024 12:55
@jmank88 jmank88 force-pushed the BCF-2978-rm-qopts-mercury branch from 126cd05 to f750598 Compare April 16, 2024 13:24
jmank88
jmank88 commented Apr 16, 2024
View reviewed changes
core/web/user_controller.go Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not related, but the usual gin context race showed up in tests for this PR so I included the standard fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split out to #12839

@jmank88 jmank88 force-pushed the BCF-2978-rm-qopts-mercury branch from f750598 to 0f698d8 Compare April 16, 2024 23:59
@jmank88 jmank88 force-pushed the BCF-2978-rm-qopts-mercury branch from 0f698d8 to 4397340 Compare April 17, 2024 00:16
@jmank88 jmank88 force-pushed the BCF-2978-rm-qopts-mercury branch from 4397340 to 16bae6b Compare April 17, 2024 00:16
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@jmank88 jmank88 marked this pull request as ready for review April 17, 2024 00:32
@jmank88 jmank88 requested a review from a team April 17, 2024 00:32
@jmank88 jmank88 requested a review from a team as a code owner April 17, 2024 00:32
@jmank88 jmank88 enabled auto-merge April 17, 2024 00:32
@jmank88 jmank88 added this pull request to the merge queue Apr 17, 2024
Merged via the queue into develop with commit 6a0b4a9 Apr 17, 2024
@jmank88 jmank88 deleted the BCF-2978-rm-qopts-mercury branch April 17, 2024 11:42
This was referenced Apr 17, 2024
Closed
Closed
This was referenced Apr 24, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimriou dimriou dimriou approved these changes

@DylanTinianov DylanTinianov Awaiting requested review from DylanTinianov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmank88 @dimriou