BCF-3043: test was not implementing the interface #12317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chainlink-common refactoring
|
I see that you haven't updated any README files. Would it make sense to do so? |
jmank88
previously approved these changes
Mar 6, 2024
cedric-cordenier
previously approved these changes
Mar 6, 2024
krehermann
dismissed stale reviews from cedric-cordenier and jmank88
via
42d6130
krehermann
changed the title
krehermann
force-pushed
the
core/fix-core-relayer-test
branch
from
42d6130 to
531a598
Compare
krehermann
force-pushed
the
core/fix-core-relayer-test
branch
from
531a598 to
278b6e4
Compare
|
cedric-cordenier
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug under covered by chainlink-common refactoring
smartcontractkit/chainlink-common@5e9c8e1
this change bumps common repo dependency to also take a fix for BCF-3044, which was found while trying to fix this bug