[KS-55] Engine and Registry improvements #12115
Conversation
bolekk
commented
Feb 21, 2024
bolekk
commented
- Move registry operations into a separate goroutine launched at Start() and supporting re-tries, to avoid race conditions on node init.
- Move most of the hardcoded workflow into Engine constructor, for clarity.
- Add missing call to consensus.RegisterToWorkflow().
- Add logger to Registry.
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
bolekk
force-pushed
the
bugfix/KS-55-engine
branch
from
9db2faa to
fd31ba0
Compare
core/services/workflows/engine.go
Outdated
| engine.targetType = "write_polygon-testnet-mumbai" | ||
| engine.targetConfig, err = values.NewMap(map[string]any{ | ||
| "address": "0xaabbcc", | ||
| "method": "updateFeedValues(report bytes)", |
There was a problem hiding this comment.
method isn't actually required, we use the function name from the abi parameter
There was a problem hiding this comment.
I noticed that you also have ChainID in the config but that's already inferred from the target type right?
| target, err := registry.GetTarget(ctx, "write_polygon_mainnet") | ||
|
|
||
| // Target | ||
| engine.targetType = "write_polygon-testnet-mumbai" |
There was a problem hiding this comment.
You caught the casing change here because of selectors 👍🏻 In the future I was thinking about replacing - -> _ to make the string more uniform, wdyt?
| LOOP: | ||
| for { |
There was a problem hiding this comment.
Rather than a retry loop, why not a oneshot channel we can close to signal after all the registration is done?
There was a problem hiding this comment.
Who would signal that? Currently our registrations are done all over the place :( In the future we can improve that but even then we could have remote capabilities being registered at arbitrary times.
1. Move registry operations into a separate goroutine launched at Start() and supporting re-tries, to avoid race conditions on node init. 2. Move most of the hardcoded workflow into Engine constructor, for clarity. 3. Add missing call to consensus.RegisterToWorkflow(). 4. Add logger to Registry.
bolekk
force-pushed
the
bugfix/KS-55-engine
branch
from
fd31ba0 to
c36e0b8
Compare
|
