Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce job spec flag for custom reverted pipeline #11529

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

kidambisrinivas
Copy link
Collaborator

Goal

  • Introduce job spec flag for custom reverted pipeline

Testing

$ cd chainlink
## Job
$ go test -count=1 -timeout=20s -v -run="^TestORM_" ./core/services/job/...
$ go test -count=1 -timeout=20s -v -run="^TestORM_CreateJob_VRFV2Plus" ./core/services/job/...

# Web
$ go test -count=1 -timeout=20s -v -run="^TestResolver_VRFSpec" ./core/web/resolver/...
$ go test -count=1 -timeout=20s -v -run="^TestJob" ./core/web/presenters/...

Copy link
Contributor

github-actions bot commented Dec 8, 2023

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

Copy link
Contributor

github-actions bot commented Dec 8, 2023

I see that you haven't updated any README files. Would it make sense to do so?

@jinhoonbang
Copy link
Contributor

let's add a check to ensure that RevertedTxPipeline cannot be enabled for VRFV2Plus - https://github.com/smartcontractkit/chainlink/blob/develop/core/services/vrf/delegate.go#L142

@kidambisrinivas kidambisrinivas requested a review from a team as a code owner December 13, 2023 20:12
jinhoonbang
jinhoonbang previously approved these changes Dec 13, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 4.2% Technical Debt Ratio on New Code (is greater than 4%)

See analysis details on SonarQube

@kidambisrinivas kidambisrinivas added this pull request to the merge queue Dec 13, 2023
Merged via the queue into develop with commit c274c23 Dec 14, 2023
80 of 81 checks passed
@kidambisrinivas kidambisrinivas deleted the chore/hdl-vrfreverts branch December 14, 2023 00:06
fbac pushed a commit that referenced this pull request Dec 14, 2023
* Introduce job spec flag for custom reverted pipeline

* Disable the flag for V2+

* Rename file after merge conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants