Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if ECR image exists before trying to publish #11495

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

chainchad
Copy link
Collaborator

To prevent failing checks like in this PR run where the PR is closed after the docker image is published and later re-opened causing the workflow to re-run and fail.

@chainchad chainchad requested review from skudasov and a team December 5, 2023 15:31
Copy link
Contributor

github-actions bot commented Dec 5, 2023

I see that you haven't updated any README files. Would it make sense to do so?

@chainchad chainchad closed this Dec 5, 2023
@chainchad chainchad reopened this Dec 5, 2023
@chainchad chainchad enabled auto-merge December 5, 2023 16:04
@chainchad chainchad added this pull request to the merge queue Dec 5, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Merged via the queue into develop with commit 9d49a20 Dec 5, 2023
155 of 157 checks passed
@chainchad chainchad deleted the re-2108/chainlink-untrusted-ecr-check-first branch December 5, 2023 16:19
fbac pushed a commit that referenced this pull request Dec 14, 2023
* Check if ECR image exists before trying to publish

* Fix role to use correct secret
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants