Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix solhint warnings #11480

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Fix solhint warnings #11480

merged 3 commits into from
Dec 4, 2023

Conversation

RensR
Copy link
Contributor

@RensR RensR commented Dec 4, 2023

Ignore older Automation folders and fix various non-automation warnings without affecting bytecode

@RensR RensR force-pushed the fix-solhint branch 2 times, most recently from 95b6237 to ae67bc3 Compare December 4, 2023 16:04
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Dec 4, 2023
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Dec 4, 2023
@RensR RensR marked this pull request as ready for review December 4, 2023 16:13
@RensR RensR requested review from a team, austinborn, Fletch153 and simsonraj as code owners December 4, 2023 16:13
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@makramkd makramkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@makramkd makramkd added this pull request to the merge queue Dec 4, 2023
Merged via the queue into develop with commit ea290be Dec 4, 2023
99 checks passed
@makramkd makramkd deleted the fix-solhint branch December 4, 2023 18:48
fbac pushed a commit that referenced this pull request Dec 14, 2023
* ignore old automation & fix minor vrf

* add more ignore and fix various non-automation

* fix gas diff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants