Fix telemetry manager health report #11397
Conversation
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
@george-dorin Can you describe the problem in more detail please? |
@cedric-cordenier updated the description with more details |
| @@ -77,7 +77,7 @@ func NewTelemetryIngressBatchClient(url *url.URL, serverPubKeyHex string, ks key | |||
| serverPubKeyHex: serverPubKeyHex, | |||
| globalLogger: lggr, | |||
| logging: logging, | |||
| lggr: lggr.Named("TelemetryIngressBatchClient"), | |||
| lggr: lggr.Named(fmt.Sprintf("TelemetryIngressBatchClient.%s.%s", network, chainID)), | |||
There was a problem hiding this comment.
Can we chain these calls in order to avoid assuming the separator is .?
| lggr: lggr.Named(fmt.Sprintf("TelemetryIngressBatchClient.%s.%s", network, chainID)), | |
| lggr: lggr.Named("TelemetryIngressBatchClient").Named(network).Named(chainID), |
There was a problem hiding this comment.
Fixed in 2fecf65
| chTelemetry: make(chan TelemPayload, telemBufferSize), | ||
| chDone: make(services.StopChan), | ||
| } | ||
| } | ||
|
|
||
| // Start connects the wsrpc client to the telemetry ingress server | ||
| func (tc *telemetryIngressClient) Start(ctx context.Context) error { | ||
| return tc.StartOnce("TelemetryIngressClient", func() error { | ||
| return tc.StartOnce(tc.lggr.Name(), func() error { |
There was a problem hiding this comment.
These were actually OK as the short name. IIRC they are only used for the error, which ends up being logged through a named logger anyways.
There was a problem hiding this comment.
Fixed in 2fecf65
|
SonarQube Quality Gate
See analysis details on SonarQube Fix issues before they fail your Quality Gate with |
* Fix incorrect health report * Add network and chainID to logger and service names * Update helpers_test * Update services name * Remove unused * Add changelog * Implement feedback
Telemetry Manager's health report was checking the health of the endpoint instead of the telemetry client of the endpoint.