Add string equivalent for observation price, bid, ask #11077
Conversation
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
SonarQube Quality Gate
|
|
LGTM, though I don't like the |
| AssetSymbol: "USD/LINK", | ||
| ObservationBenchmarkPriceString: "111111", | ||
| ObservationBidString: "222222", | ||
| ObservationAskString: "333333", |
There was a problem hiding this comment.
@george-dorin What is the plan (assuming there is one) for dropping support for the old fields from the proto?
There was a problem hiding this comment.
Thinking about this a bit more 🤔 If the current value is garbage, is there any harm in dropping the old field?
Old code would still be sending the old field, so as long as the telemetry pipeline can interpret both we shouldn't have a problem.
There was a problem hiding this comment.
There is a mechanism for reserving the deprecated fields: https://protobuf.dev/programming-guides/proto3/#deleting
There was a problem hiding this comment.
The plan is to reserve them further down the line so we don't have to have two versions of the protobuf in the ingestion server.
Due to the increase in the mercury precision
enhancedEAMercuryobservation values no longer fit intoint64. Work around this issue by adding the string equivalents of the benchmarkPrice, bid and ask observation values.