Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golangci-lint to 1.55.0 #11037

Merged
merged 2 commits into from
Oct 23, 2023
Merged

bump golangci-lint to 1.55.0 #11037

merged 2 commits into from
Oct 23, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Oct 23, 2023

Bump and fix new issues:

  • File is not goimports-ed with -local X (goimports)

  • superfluous-else: if block ends with a continue statement, so drop this else and outdent its block (revive)

  • indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)

  • dot-imports: should not use dot imports (revive)

Old glitch still remains:

plugins/config_test.go:90: File is not `goimports`-ed with -local github.com/smartcontractkit/chainlink (goimports)
func (m *MockEnvConfig) PrometheusPort() int { return 9090 }
func (m *MockEnvConfig) TracingEnabled() bool { return true }
plugins/loop_registry_test.go:32: File is not `goimports`-ed with -local github.com/smartcontractkit/chainlink (goimports)
func (m *MockCfgTracing) Enabled() bool { return true }

- superfluous-else: if block ends with a continue statement, so drop this else and outdent its block (revive)

- indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)

- dot-imports: should not use dot imports (revive)
@github-actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@jmank88 jmank88 enabled auto-merge October 23, 2023 14:15
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 70.0% 70.0% Coverage on New Code (is less than 75%)

See analysis details on SonarQube

@jmank88 jmank88 added this pull request to the merge queue Oct 23, 2023
Merged via the queue into develop with commit a9ddfa1 Oct 23, 2023
@jmank88 jmank88 deleted the golangci-lint-1.55 branch October 23, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants