Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove -tags test in favor of testing.Testing() #10853

Merged
merged 1 commit into from
Oct 4, 2023
Merged

remove -tags test in favor of testing.Testing() #10853

merged 1 commit into from
Oct 4, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Oct 3, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@jmank88 jmank88 force-pushed the BCF-2650-rm-tags-test branch from 0fff92f to c617a30 Compare October 3, 2023 16:41
@jmank88 jmank88 force-pushed the BCF-2650-rm-tags-test branch from c617a30 to 35a345e Compare October 3, 2023 16:45
jmank88
jmank88 commented Oct 3, 2023
View reviewed changes
core/config/toml/types_test.go
@@ -143,7 +143,7 @@ func TestValidateConfig(t *testing.T) {
URL: &validSecretURL,
AllowSimplePasswords: &[]bool{true}[0],
},
skip: !build.IsProd(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would always be skipped since a func Test from a _test.go is only compiled in to test binaries. Instead, we test an unexported helper method that accepts a build mode parameter.

@jmank88 jmank88 requested a review from essamhassan October 3, 2023 16:48
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 72.7% 72.7% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@jmank88 jmank88 requested a review from a team October 4, 2023 10:23
essamhassan
essamhassan approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@essamhassan essamhassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks Jordan!

@jmank88 jmank88 added this pull request to the merge queue Oct 4, 2023
Merged via the queue into develop with commit 346c942 Oct 4, 2023
@jmank88 jmank88 deleted the BCF-2650-rm-tags-test branch October 4, 2023 14:11
@snehaagni snehaagni mentioned this pull request Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chainchad chainchad chainchad approved these changes

@essamhassan essamhassan essamhassan approved these changes

@javuto javuto Awaiting requested review from javuto

@jkongie jkongie Awaiting requested review from jkongie

@samsondav samsondav Awaiting requested review from samsondav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmank88 @essamhassan @chainchad