-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BCF 2440 remove chainsets from core #10349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BCI-1738/cosmos-cleanup
samsondav
requested changes
Aug 28, 2023
jmank88
reviewed
Aug 29, 2023
jmank88
reviewed
Aug 29, 2023
jmank88
reviewed
Aug 29, 2023
jmank88
reviewed
Aug 29, 2023
…name code for clarity
krehermann
force-pushed
the
BCF-2441-update-loop-interface
branch
from
August 29, 2023 20:13
3efef0a
to
6b519a9
Compare
jmank88
reviewed
Aug 30, 2023
jmank88
reviewed
Aug 30, 2023
nit/ The branch is prefixed as |
krehermann
force-pushed
the
BCF-2441-update-loop-interface
branch
from
August 30, 2023 17:26
4df5db7
to
1153e16
Compare
jmank88
approved these changes
Aug 30, 2023
jmank88
approved these changes
Aug 30, 2023
samsondav
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key points to this are:
BCF-2317 hid all the chainset from public API with the core node
BCF-2564 updated all the chain-specific repos to accept a chain instead of a chainset
The main thrust of this change is
However, there are some contortions needed to accomplish this while maintain compatibility with the existing loop.Relayer interface.
We have to maintain funcs that had been on the ChainSet implementations:
We do this with foresight about BCF-2441, which is drafted here: smartcontractkit/chainlink-common#158, and proposes to replace these interface funcs with
Therefore, there are two aspects to playing nicely with the loop.Relayer interface. First is maintaining the exist required funcs in the interface. Second is preemptively adding support for the new interface definition that is drafted above.
In order to ensure an easy transition when BFC-2441 lands, we implement the new funcs and in turn implement the old funcs in terms of them. This is quite nice because we can use all of the existing tests to ensure our new interface funcs are correct. For non-evm chains this can be done in one place, in the RelayExt and RelayAdapter: We define the existing interface funcs on this struct and implement them in terms of the chain that they receive during construction.
EVM is a little more complex, which is to be excepted.
Once BCF-2441 is merged, and we will update this repo to remove all the deleted funcs and expose the already-implemented funcs in there place. There are many TODOs marking the places that can and will be simplified.