Open
Conversation
|
👋 Tofel, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional pprof dumping in the CL nodes leak detector so leak checks can persist both allocation and in-use memory profiles for post-test analysis.
Changes:
- Dump two Pyroscope memory profiles during
CLNodesLeakDetector.Check: alloc (default) and inuse. - Add per-profile output naming and log the saved profile type/path.
- Add a framework changeset note for the new behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| framework/leak/detector_cl_node.go | Updates leak check to download and save multiple memory pprof profiles (alloc + inuse) with distinct output names and logging. |
| framework/.changeset/v0.15.16.md | Documents the new behavior in the changelog/changeset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tofel
force-pushed
the
dx-3763-dump-two-profiles
branch
from
f97fa25 to
cf09c89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.