AWSSecretsManager wrapper #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skudasov
force-pushed
the
try-aws-secrets
branch
from
c56fb80
to
9cb2beb
Compare
skudasov
force-pushed
the
try-aws-secrets
branch
from
9cb2beb
to
6f315e9
Compare
gheorghestrimtu
approved these changes
Aug 21, 2024
lukaszcl
approved these changes
Aug 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a simple wrapper on top of AWS Secrets Manager, allowing us to create/read/delete secrets and protecting them from accidental printing.
E2E tests will be enabled in next PRs when we issue proper creds for that.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes introduce AWS Secrets Manager integration for handling secrets within the application securely. This includes adding functionality to create, retrieve, and delete secrets programmatically via a new
client/secretsmanager.gofile and documentation on how to use these features and interact with AWS Secrets Manager via CLI. The updates ingo.modandgo.sumreflect new dependencies required for AWS SDK to support these operations.What
SECRETS.mddocumentation.AWSSecretsManagerstruct andAWSSecrettype to handle secrets securely.secretsmanager.gofunctionality, ensuring secrets are managed correctly through unit tests.aws-sdk-go-v2/config,aws-sdk-go-v2/service/secretsmanager) necessary for interacting with AWS Secrets Manager. The updates include direct and indirect dependencies to support these additions.