-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a SetConfig function to the LogEventProvider interface #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 4, 2024
df2ee27
to
f5fafe4
Compare
amirylm
approved these changes
Mar 7, 2024
9e13761
to
0fbc657
Compare
0fbc657
to
b03deb2
Compare
jmank88
previously approved these changes
Mar 22, 2024
60c84f8
to
6d37008
Compare
6d37008
to
b5f6f5e
Compare
b5f6f5e
to
b17c24f
Compare
b17c24f
to
b0c601a
Compare
Update to latest config Reduce config options
b0c601a
to
5be305d
Compare
jmank88
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/AUTO-9023
In this PR, we're updating the LogEventProvider interface with a means of setting config values, internal to the log event provider implementation
Compared to the earlier implementation of this PR, we're now defining the config values as floats instead of uint32s
Related PRs