Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract core/store/models #296

Merged
merged 16 commits into from
Jan 8, 2024
Merged

Extract core/store/models #296

merged 16 commits into from
Jan 8, 2024

Conversation

DylanTinianov
Copy link
Collaborator

@DylanTinianov DylanTinianov commented Dec 19, 2023 •
edited
Loading

Add common models for Duration and URL

@DylanTinianov DylanTinianov self-assigned this Dec 19, 2023
@DylanTinianov DylanTinianov marked this pull request as ready for review December 19, 2023 18:30
jmank88
jmank88 reviewed Jan 4, 2024
View reviewed changes
pkg/config/duration.go Outdated Show resolved Hide resolved
jmank88
jmank88 reviewed Jan 4, 2024
View reviewed changes
pkg/config/duration.go Outdated Show resolved Hide resolved
jmank88
jmank88 previously approved these changes Jan 4, 2024
View reviewed changes
@DylanTinianov DylanTinianov merged commit 237f56d into main Jan 8, 2024
7 of 8 checks passed
@DylanTinianov DylanTinianov deleted the BCI-2531-extract-core-store-models branch January 8, 2024 18:23
ettec pushed a commit that referenced this pull request Mar 28, 2024
@DylanTinianov @ettec
Extract core/store/models (#296)
f417e8c 
* Create duration.go

* Update duration.go

* extract url

* Update duration.go

* fix imports

* lint

* Create duration_test.go

* update url

* move duration to sqlutil

* Move Duration to config

* Only use NewDuration

* Update duration_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimriou dimriou dimriou approved these changes

@amit-momin amit-momin amit-momin approved these changes

@krebernisak krebernisak Awaiting requested review from krebernisak

@krehermann krehermann Awaiting requested review from krehermann

@jmank88 jmank88 Awaiting requested review from jmank88

Assignees

@DylanTinianov DylanTinianov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DylanTinianov @jmank88 @krehermann @dimriou @amit-momin