Update github workflows to parse custom versions for external builds #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a, and starknet builds
ferglor
changed the title
ferglor
changed the title
jmank88
approved these changes
Dec 12, 2023
tateexon
approved these changes
Dec 12, 2023
krehermann
approved these changes
Dec 12, 2023
samsondav
pushed a commit
that referenced
this pull request
Jan 11, 2024
ettec
pushed a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the workflows to read the PR description for custom refs to build against for each of the three external builds. If no refs are specified, "develop" is used.
When I introduced interface changes to
chainlink-common, the three external builds for core, solana, and starknet failed, because those builds were using the develop version of each repository, which didn't account for the interface changes I had inchainlink-common. By specifying custom refs for commits that honor the interface changes in each of the three external repos in the PR description, the CI jobs are able to build successfully.See this change in action on this PR: #285
See how CI failed without the workflow updates: https://github.com/smartcontractkit/chainlink-common/actions/runs/7183403401