Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solana: porting over contracts #366

Merged
merged 13 commits into from
Dec 17, 2024
Merged

solana: porting over contracts #366

merged 13 commits into from
Dec 17, 2024

Conversation

aalu1418
Copy link
Collaborator

@aalu1418 aalu1418 commented Dec 12, 2024 •
edited
Loading

  • copy over contracts + tests
    • cleanup .gitignore
  • enable CI cached image
  • enable CI for rust + golang tests
  • enable CI for checking generated artifacts
  • reorganize tests

aalu1418 and others added 2 commits December 12, 2024 12:21
@aalu1418 @agusaldasoro
@toblich @jadepark-dev @PabloMansanet
solana: porting over contracts
7ecc431 
Co-authored-by: Agustina Aldasoro <agusaldasoro@users.noreply.github.com>
Co-authored-by: Tobías Lichtig <toblich@users.noreply.github.com>
Co-authored-by: Jonghyeon Park <jonghyeon.park@smartcontract.com>
Co-authored-by: PabloMansanet <pablomansanet@gmail.com>
@aalu1418
cleanup gitignore
7d87424
@aalu1418 aalu1418 force-pushed the solana/init-ccip-contracts branch from 4c326b9 to e07d96f Compare December 13, 2024 16:13
@aalu1418 aalu1418 force-pushed the solana/init-ccip-contracts branch 4 times, most recently from eb740b8 to 99166ba Compare December 13, 2024 16:58
@aalu1418 aalu1418 force-pushed the solana/init-ccip-contracts branch 4 times, most recently from ae2f2f5 to c255d58 Compare December 13, 2024 18:08
@aalu1418 aalu1418 force-pushed the solana/init-ccip-contracts branch from c255d58 to cff49ff Compare December 13, 2024 18:15
@aalu1418 aalu1418 marked this pull request as ready for review December 13, 2024 22:16
@aalu1418 aalu1418 requested a review from a team as a code owner December 13, 2024 22:16
@aalu1418 @agusaldasoro
Update chains/solana/.gitignore
7845f3a 
Co-authored-by: Agustina Aldasoro <agusaldasoro@users.noreply.github.com>
agusaldasoro
agusaldasoro reviewed Dec 16, 2024
View reviewed changes
.github/workflows/solana.yml
@@ -0,0 +1,203 @@
name: Solana
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we migrate the .pre-commit-config.yaml as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just the minimum set to keep developing - if you want to migrate it, you're definitely welcome to make another PR :)

agusaldasoro
agusaldasoro previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@agusaldasoro agusaldasoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@github-actions GitHub Actions
Copy link

Metric solana/init-ccip-contracts main
Coverage 76.8% 76.7%

@aalu1418 aalu1418 merged commit 814a10a into main Dec 17, 2024
17 checks passed
@winder winder deleted the solana/init-ccip-contracts branch December 17, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winder winder winder approved these changes

@agusaldasoro agusaldasoro agusaldasoro left review comments

@rstout rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aalu1418 @winder @agusaldasoro