Commit plugin improvements #297
Conversation
dimkouv
commented
Nov 5, 2024
dimkouv
commented
- Compute RMN initial request timers expiration according to MaxQueryDuration instead of having it hardcoded.
- Logging improvements.
- Minor refactoring.
dimkouv
requested review from
winder,
rstout,
asoliman92,
makramkd,
mateusz-sekara,
0xAustinWang and
0xnogo
|
| // remaining 5% for other query processing | ||
|
|
||
| maxAllowedObservationTimeout = 3 * time.Second | ||
| maxAllowedReportTimeout = 2 * time.Second |
There was a problem hiding this comment.
for my own knowledge, would these values change depending on the chain?
There was a problem hiding this comment.
They shouldn't because these are parameters for communication w/ RMN which is purely offchain
| queryCapacityForReports := time.Duration(reportDurationPercentage * float64(maxQueryDuration)) | ||
|
|
||
| // we divide in two parts one for the initial signatures request and one for the retry | ||
| queryCapacityForInitialObservations := queryCapacityForReports / 2 |
There was a problem hiding this comment.
is this division something we would want to potentially tune?
for example, 70% for initial signatures, 30% for retry
There was a problem hiding this comment.
Good question! I think we'd want to give enough time for the retries, splitting them 70/30 might not be enough for the retries.
There was a problem hiding this comment.
Good point, right now it is set to 50% for the initial try and 50% for the retry. We can adjust this if required.
| // remaining 5% for other query processing | ||
|
|
||
| maxAllowedObservationTimeout = 3 * time.Second | ||
| maxAllowedReportTimeout = 2 * time.Second |
There was a problem hiding this comment.
They shouldn't because these are parameters for communication w/ RMN which is purely offchain
| queryCapacityForReports := time.Duration(reportDurationPercentage * float64(maxQueryDuration)) | ||
|
|
||
| // we divide in two parts one for the initial signatures request and one for the retry | ||
| queryCapacityForInitialObservations := queryCapacityForReports / 2 |
There was a problem hiding this comment.
Good question! I think we'd want to give enough time for the retries, splitting them 70/30 might not be enough for the retries.
