Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-Audit fixes part 2 #287

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Self-Audit fixes part 2 #287

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6203a1a
fix: CCIP-4065
makramkd Oct 31, 2024
51b9fb7
fix: CCIP-4070
makramkd Nov 1, 2024
b7b24c8
fix: CCIP-4071
makramkd Nov 1, 2024
2d91d5b
fix: CCIP-4074
makramkd Nov 1, 2024
77f50a8
Merge branch 'main' into mk/self-audit-fixes-part2
makramkd Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: CCIP-4074
  • Loading branch information
@makramkd
makramkd committed Nov 1, 2024
commit 2d91d5b83b52211b03cb80214bf8b8d9ed27d2b5
6 changes: 3 additions & 3 deletions commit/tokenprice/processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,13 @@ func (p *processor) Outcome(

consensusObservation, err := p.getConsensusObservation(aos)
if err != nil {
return Outcome{}, err
return Outcome{}, fmt.Errorf("get consensus observation: %w", err)
}

tokenPriceOutcome := p.selectTokensForUpdate(consensusObservation)
p.lggr.Infow(
"outcome token prices",
"token prices", tokenPriceOutcome,
"tokenPrices", tokenPriceOutcome,
)
return Outcome{
TokenPrices: tokenPriceOutcome,
Expand All @@ -103,7 +103,7 @@ func validateObservedTokenPrices(tokenPrices []cciptypes.TokenPrice) error {
tokensWithPrice.Add(t.TokenID)

if t.Price.IsEmpty() {
return fmt.Errorf("token price must not be empty")
return fmt.Errorf("token price of token %v must not be empty", t.TokenID)
}
}
return nil
Expand Down
Loading