Migrate to ops gen v2#2183
Draft
RensR wants to merge 2 commits into
Draft
Conversation
RensR
force-pushed
the
ops-gen-v2
branch
6 times, most recently
from
9d11352 to
30f637c
Compare
fixup: convert remaining pre-existing v1_6_0/v2_0_0 fee & token adapter code to ops-gen v2 pattern These files already existed on main (or were auto-merged in via rename detection) using the old contract/operations.ExecuteOperation calling convention, referencing types deleted by the migration. Converts them to the same evmops.ExecuteRead/ExecuteWrite pattern used everywhere else in this PR.
…nput configure_token_for_transfers.go (added by the ops-gen v2 migration) references input.LiquidityMigrationAmount, .LiquidityMigrationBasisPoints, and .TimelockAddress to optionally trigger MigrateLockReleasePoolLiquidity inline, but these fields were never added to the input struct in any of the original commits. Adding them here, isolated for review, since this completes a previously non-compiling feature rather than just resolving a merge conflict.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.