Add SignObservationPrefix in the OffchainConfig #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimkouv
reviewed
Oct 4, 2024
makramkd
approved these changes
Oct 4, 2024
|
makramkd
added a commit
that referenced
this pull request
Oct 9, 2024
* Change OCR3Config to reflect latest CCIPHome changes Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * Change OCR3ConfigWithMeta to mirror latest CCIPHome Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * Expose OCR3Node Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * ChainConfigInfo => ChainConfigArgs Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * Revert "ChainConfigInfo => ChainConfigArgs" This reverts commit d433a65. * Fix ActiveCandidate return type from contract Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * Fix Json name for candidate config Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * Change Active Candidate to concrete types instead of pointers * debugging * debugging cl-common * Use `GetAllConfigs` in expected mock argument * Small fixes * debugging with cl-common * debugging with cl-common * cleaning round and use latest cl-common * Remove CommitPluginConfig and use OffchainConfig instead (#195) * Use digest instead of version to determine activity * Deprecating the ExecutePluginConfig (#203) * Remove non-necessary plugin Close calls (#202) * remove non-necessary plugin Close calls * remov Close() from ccipReader * Add SignObservationPrefix in the OffchainConfig (#208) * Move exec Observation into a separate file. (#205) * Move exec Outcome into a separate file. (#206) * CCIP-3664 Single rate limiter per attestation http client (#209) * rename blue-green to active-candidate * RMN config integration (#211) * bump cl-common * Revert "bump cl-common" This reverts commit 58e5f5b. * WIP bump cl-common Add OnRampAddress * Fix onRamp with merkleRoot * Add dummy RMNRawVs * Implement ccipChainReader.LinkPriceUSD() (#207) * logging updates * Fix the QueryCheck method (#213) * fix ccip reader * typos * commit/merkleroot: use auxilliary type as set key (#215) * bump chainlink-common --------- Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> Co-authored-by: nogo <110664798+0xnogo@users.noreply.github.com> Co-authored-by: dimitris <dimitrios.kouveris@smartcontract.com> Co-authored-by: Will Winder <wwinder.unh@gmail.com> Co-authored-by: Mateusz Sekara <mateusz.sekara@gmail.com> Co-authored-by: Ryan Stout <rstout610@gmail.com> Co-authored-by: Makram Kamaleddine <makramkd@users.noreply.github.com>
makramkd
added a commit
that referenced
this pull request
Oct 9, 2024
* Fix homechain ocr3 (#199) * Change OCR3Config to reflect latest CCIPHome changes Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * Change OCR3ConfigWithMeta to mirror latest CCIPHome Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * Expose OCR3Node Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * ChainConfigInfo => ChainConfigArgs Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * Revert "ChainConfigInfo => ChainConfigArgs" This reverts commit d433a65. * Fix ActiveCandidate return type from contract Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * Fix Json name for candidate config Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * Change Active Candidate to concrete types instead of pointers * debugging * debugging cl-common * Use `GetAllConfigs` in expected mock argument * Small fixes * debugging with cl-common * debugging with cl-common * cleaning round and use latest cl-common * Remove CommitPluginConfig and use OffchainConfig instead (#195) * Use digest instead of version to determine activity * Deprecating the ExecutePluginConfig (#203) * Remove non-necessary plugin Close calls (#202) * remove non-necessary plugin Close calls * remov Close() from ccipReader * Add SignObservationPrefix in the OffchainConfig (#208) * Move exec Observation into a separate file. (#205) * Move exec Outcome into a separate file. (#206) * CCIP-3664 Single rate limiter per attestation http client (#209) * rename blue-green to active-candidate * RMN config integration (#211) * bump cl-common * Revert "bump cl-common" This reverts commit 58e5f5b. * WIP bump cl-common Add OnRampAddress * Fix onRamp with merkleRoot * Add dummy RMNRawVs * Implement ccipChainReader.LinkPriceUSD() (#207) * logging updates * Fix the QueryCheck method (#213) * fix ccip reader * typos * commit/merkleroot: use auxilliary type as set key (#215) * bump chainlink-common --------- Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> Co-authored-by: nogo <110664798+0xnogo@users.noreply.github.com> Co-authored-by: dimitris <dimitrios.kouveris@smartcontract.com> Co-authored-by: Will Winder <wwinder.unh@gmail.com> Co-authored-by: Mateusz Sekara <mateusz.sekara@gmail.com> Co-authored-by: Ryan Stout <rstout610@gmail.com> Co-authored-by: Makram Kamaleddine <makramkd@users.noreply.github.com> * misc fixes * fix commit e2e test * address comments * fix nolint comments * fix test * Use string() instead of hex.EncodeToString Co-authored-by: Will Winder <wwinder.unh@gmail.com> * fix build --------- Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> Co-authored-by: Abdelrahman Soliman (Boda) <2677789+asoliman92@users.noreply.github.com> Co-authored-by: nogo <110664798+0xnogo@users.noreply.github.com> Co-authored-by: dimitris <dimitrios.kouveris@smartcontract.com> Co-authored-by: Will Winder <wwinder.unh@gmail.com> Co-authored-by: Mateusz Sekara <mateusz.sekara@gmail.com> Co-authored-by: Ryan Stout <rstout610@gmail.com>
winder
added a commit
that referenced
this pull request
Oct 10, 2024
* Fix homechain ocr3 (#199) * Change OCR3Config to reflect latest CCIPHome changes Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * Change OCR3ConfigWithMeta to mirror latest CCIPHome Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * Expose OCR3Node Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * ChainConfigInfo => ChainConfigArgs Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * Revert "ChainConfigInfo => ChainConfigArgs" This reverts commit d433a65. * Fix ActiveCandidate return type from contract Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * Fix Json name for candidate config Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> * Change Active Candidate to concrete types instead of pointers * debugging * debugging cl-common * Use `GetAllConfigs` in expected mock argument * Small fixes * debugging with cl-common * debugging with cl-common * cleaning round and use latest cl-common * Remove CommitPluginConfig and use OffchainConfig instead (#195) * Use digest instead of version to determine activity * Deprecating the ExecutePluginConfig (#203) * Remove non-necessary plugin Close calls (#202) * remove non-necessary plugin Close calls * remov Close() from ccipReader * Add SignObservationPrefix in the OffchainConfig (#208) * Move exec Observation into a separate file. (#205) * Move exec Outcome into a separate file. (#206) * CCIP-3664 Single rate limiter per attestation http client (#209) * rename blue-green to active-candidate * RMN config integration (#211) * bump cl-common * Revert "bump cl-common" This reverts commit 58e5f5b. * WIP bump cl-common Add OnRampAddress * Fix onRamp with merkleRoot * Add dummy RMNRawVs * Implement ccipChainReader.LinkPriceUSD() (#207) * logging updates * Fix the QueryCheck method (#213) * fix ccip reader * typos * commit/merkleroot: use auxilliary type as set key (#215) * bump chainlink-common --------- Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> Co-authored-by: nogo <110664798+0xnogo@users.noreply.github.com> Co-authored-by: dimitris <dimitrios.kouveris@smartcontract.com> Co-authored-by: Will Winder <wwinder.unh@gmail.com> Co-authored-by: Mateusz Sekara <mateusz.sekara@gmail.com> Co-authored-by: Ryan Stout <rstout610@gmail.com> Co-authored-by: Makram Kamaleddine <makramkd@users.noreply.github.com> * misc fixes * fix commit e2e test * address comments * fix nolint comments * fix test * Use string() instead of hex.EncodeToString Co-authored-by: Will Winder <wwinder.unh@gmail.com> * fix build --------- Signed-off-by: asoliman <abdelrahman.soliman@smartcontract.com> Co-authored-by: Abdelrahman Soliman (Boda) <2677789+asoliman92@users.noreply.github.com> Co-authored-by: nogo <110664798+0xnogo@users.noreply.github.com> Co-authored-by: dimitris <dimitrios.kouveris@smartcontract.com> Co-authored-by: Will Winder <wwinder.unh@gmail.com> Co-authored-by: Mateusz Sekara <mateusz.sekara@gmail.com> Co-authored-by: Ryan Stout <rstout610@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SignObservationPrefix Is not part of the onchain RMN config. Hence adding it in the CommitOffchainConfig.