Open
Conversation
RensR
commented
Feb 4, 2026
|
|
||
| .PHONY: operations | ||
| operations: pnpmdep | ||
| #./scripts/compile_all |
Collaborator
Author
There was a problem hiding this comment.
Should have been on, turning it off makes it quicker but could lead to wrong ops being generated
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for view functions with parameters by implementing read operations for contract getter functions across multiple CCIP versions (1.6.0, 1.6.1). The changes enable generation of read operations for view functions that accept parameters, previously limited to write operations only.
Changes:
- Extended operations generator to create Args structs for read operations with multiple parameters
- Added read/view contract methods (getToken, getRouter, getDestChainConfig, etc.) to TokenPool, OnRamp, OffRamp, and FeeQuoter contracts
- Updated type references in sequences to use local operation types instead of generated gobindings
- Uncommented compilation script in Makefile to enable operations generation
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| chains/evm/deployment/v1_6_4/changesets/apply_chain_updates_test.go | Reordered import statement for burn_mint_erc20 |
| chains/evm/deployment/v1_6_1/operations/token_pool/token_pool.go | Added view functions and supporting types for TokenPool contract operations |
| chains/evm/deployment/v1_6_0/sequences/onramp.go | Updated type references to use local operation types and changed function input types from any to struct{} |
| chains/evm/deployment/v1_6_0/sequences/offramp.go | Updated type references to use local operation types and changed function input types |
| chains/evm/deployment/v1_6_0/sequences/fee_quoter.go | Renamed GetTokenTransferFeeConfigInput to GetTokenTransferFeeConfigArgs and updated type references |
| chains/evm/deployment/v1_6_0/operations/onramp/onramp.go | Added view functions with parameter support and replaced gobindings usage with local types |
| chains/evm/deployment/v1_6_0/operations/offramp/offramp.go | Added view functions and SourceChainConfig struct, replaced gobindings with local types |
| chains/evm/deployment/v1_6_0/operations/fee_quoter/fee_quoter.go | Added view functions and renamed GetTokenTransferFeeConfigInput to GetTokenTransferFeeConfigArgs |
| chains/evm/deployment/operations_gen_config.yaml | Added public view functions to contract configurations |
| chains/evm/cmd/operations-gen/operations.tmpl | Renamed WriteArgStructs to ArgStructs to support both read and write operations |
| chains/evm/cmd/operations-gen/main.go | Added Args struct generation for read operations with multiple parameters |
| chains/evm/GNUmakefile | Uncommented compile_all script to enable operations generation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds view parameter support and generates all the functions that are used on the develop branch for v2. This is done on main because main is the place where 1.6 changes should be made, while develop is for 1.7 only.