USDC Token Pool Liquidity migration changeset#1603
Open
0xsuryansh wants to merge 15 commits intodevelopfrom
Open
USDC Token Pool Liquidity migration changeset#16030xsuryansh wants to merge 15 commits intodevelopfrom
0xsuryansh wants to merge 15 commits intodevelopfrom
Conversation
| return MigrateHybridLockReleaseLiquidityOutput{}, err | ||
| } | ||
|
|
||
| addresses := make([]datastore.AddressRef, 0) |
There was a problem hiding this comment.
This is not populated because the sequence doesn't deploy anything right?
# Conflicts: # ccv/chains/evm/deployment/go.mod # ccv/chains/evm/deployment/go.sum
0xsuryansh
force-pushed
the
liquidity-migration
branch
from
bc9970f to
3c0c3c3
Compare
# Conflicts: # ccv/chains/evm/deployment/go.mod # ccv/chains/evm/deployment/go.sum
# Conflicts: # ccv/chains/evm/deployment/go.mod # ccv/chains/evm/deployment/go.sum
|
kylesmartin
reviewed
Feb 2, 2026
| if err != nil { | ||
| return MigrateHybridLockReleaseLiquidityOutput{}, fmt.Errorf("failed to get authorized callers for lockbox %s (chain %d): %w", lockBox, sel, err) | ||
| } | ||
| if containsAddress(callersReport.Output, siloedPoolAddr) { |
| }, | ||
| }) | ||
| if err != nil { | ||
| return MigrateHybridLockReleaseLiquidityOutput{}, fmt.Errorf("failed to authorize siloed pool on lockbox %s (chain %d): %w", lockBox, sel, err) |
Contributor
There was a problem hiding this comment.
Isn't this already done in the initial setup of the SiloedUSDC?
Comment on lines
+153
to
+154
| withdrawAmount := new(big.Int).Mul(lockedReport.Output, big.NewInt(int64(input.LiquidityWithdrawPercent))) | ||
| withdrawAmount.Div(withdrawAmount, big.NewInt(100)) |
Contributor
There was a problem hiding this comment.
Could we have a test that confirms that this liquidity transfer works as expected?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.