-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astar & Hedera changes cherry-picked #1324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* No new finalized Heads Implementation * fixed tests * update defaults for NoNewFinalizedHeadsThreshold * Update common/client/node_lifecycle.go Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com> * Update common/client/node_lifecycle_test.go Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com> * Update common/client/node_lifecycle_test.go Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com> * rename HeadIsNotIncreasing to NoNewHead * move and add docs for syncIssue consts * rename syncIssue to syncStatus --------- Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com>
* allow to configure RPCTimeouts * Custom (30s) timeout for Hedera RPC requests with large payloads (SendTransaction, CallContext, etc.) * fix linter
* Added post-broadcast nonce validation for Hedera * Added changeset * Updated chaintype docs for Hedera * Fixed lint errors * Added condition to handle on-chain seq less than tx seq and updated comment
* Custom Astar finality * fix merge artifact * fix lint issue * simplify isRequestingFinalizedBlock * avoid iterating through the whole batch again * fix errors wrapping
simsonraj
changed the title
Astar & hedera changes cherrypick
[DRAFT] - Do not merge yet: Astar & hedera changes cherrypick
Aug 19, 2024
flodesi
reviewed
Aug 19, 2024
simsonraj
changed the title
[DRAFT] - Do not merge yet: Astar & hedera changes cherrypick
Astar & hedera changes cherry-picked
Aug 19, 2024
simsonraj
changed the title
Astar & hedera changes cherry-picked
Astar & Hedera changes cherry-picked
Aug 19, 2024
RensR
approved these changes
Aug 20, 2024
friedemannf
approved these changes
Aug 20, 2024
mateusz-sekara
approved these changes
Aug 20, 2024
Quality Gate passedIssues Measures |
flodesi
added a commit
that referenced
this pull request
Aug 23, 2024
## Motivation following the [cherry pick for astar custom finaility from chainlink repo](#1324), need to enable it for astar ## Solution --------- Co-authored-by: Finley Decker <finleydecker@gmail.com> Co-authored-by: Balamurali Gopalswami <167726375+b-gopalswami@users.noreply.github.com>
AnieeG
pushed a commit
that referenced
this pull request
Aug 28, 2024
## Motivation following the [cherry pick for astar custom finaility from chainlink repo](#1324), need to enable it for astar ## Solution --------- Co-authored-by: Finley Decker <finleydecker@gmail.com> Co-authored-by: Balamurali Gopalswami <167726375+b-gopalswami@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cherry-pick of smartcontractkit/chainlink#14021
cherry-pick of smartcontractkit/chainlink#13957
cherry-pick of smartcontractkit/chainlink#13876
cherry-pick of smartcontractkit/chainlink#13907
Solution