Skip to content

feat(cct-sdk): Add accept admin evm op - #328

Open
apedrob wants to merge 1 commit into
feature/DAPP-10818-evm-transfer-adminfrom
feature/DAPP-10819-evm-accept-admin
Open

feat(cct-sdk): Add accept admin evm op#328
apedrob wants to merge 1 commit into
feature/DAPP-10818-evm-transfer-adminfrom
feature/DAPP-10819-evm-accept-admin

Conversation

@apedrob

@apedrob apedrob commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What

  • Add acceptAdmin to EVMTokenManager, encoding acceptAdminRole. Completes the two-step admin transfer flow.

Why

  • Closes the registry flow on Token Admin Registry

Testing

  • Unit tests cover the encoding, the cases where nothing is pending or the caller is not the pending administrator + wallet binding

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

You must have Developer access to commit code to Chainlink Labs on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

@apedrob
apedrob force-pushed the feature/DAPP-10819-evm-accept-admin branch from 0c232dc to f0ff200 Compare August 6, 2026 00:06
@apedrob
apedrob changed the base branch from cct-sdk to feature/DAPP-10823-get-token-pool-state August 6, 2026 10:28
@apedrob
apedrob force-pushed the feature/DAPP-10819-evm-accept-admin branch 2 times, most recently from ded8dba to 243b7d9 Compare August 6, 2026 11:01
@apedrob
apedrob changed the base branch from feature/DAPP-10823-get-token-pool-state to feature/DAPP-10818-evm-transfer-admin August 6, 2026 11:07
@apedrob
apedrob force-pushed the feature/DAPP-10819-evm-accept-admin branch from 243b7d9 to 1e784c5 Compare August 6, 2026 11:10
@apedrob
apedrob force-pushed the feature/DAPP-10818-evm-transfer-admin branch from 1df894d to 34ec0b0 Compare August 6, 2026 11:32
@apedrob
apedrob force-pushed the feature/DAPP-10819-evm-accept-admin branch from 1e784c5 to 549b432 Compare August 6, 2026 11:33
@apedrob apedrob changed the title feat(cct-sdk): Add acceptAdmin EVM op feat(cct-sdk): Add accept admin evm op Aug 6, 2026
@apedrob
apedrob force-pushed the feature/DAPP-10818-evm-transfer-admin branch from 34ec0b0 to bf7feb3 Compare August 6, 2026 11:54
@apedrob
apedrob force-pushed the feature/DAPP-10819-evm-accept-admin branch from 549b432 to d9aa28f Compare August 6, 2026 11:55
@apedrob
apedrob marked this pull request as ready for review August 6, 2026 12:03
@apedrob
apedrob requested review from a team, PabloMansanet and aelmanaa as code owners August 6, 2026 12:03
@apedrob
apedrob requested a review from mervin-link August 6, 2026 12:03
aelmanaa

This comment was marked as outdated.

@aelmanaa

aelmanaa commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

✅ APPROVE — acceptAdmin (EVM)

Head d9aa28f · base feature/DAPP-10818-evm-transfer-admin. ✅ APPROVE — 0 blockers.

Tested live on Sepolia (token 0x6a2674…597FE):

  • accept completes registration: tx (admin set, pending cleared)

  • W2 handoff accept: tx

  • non-pending caller rejected pre-flight with the named CCTParamsInvalidError (not raw OnlyPendingAdministrator)

  • 17/17 op tests · npm run check exit 0

Comments: none op-specific — the earlier untyped-read/unnamed-error issue is fixed here.

Cross-cutting (not this PR): TokenManager base declares no abstract admin ops, so EVM↔Solana admin-op parity is convention, not compiler-enforced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants