Update fan 1080.json and add 1081.json #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit utilized the wrong manufacturer (Hamilton Bay) when it should have been Harbor Breeze. Added model of remote unit (FCC ID) to the supported model list
Added second Harbor Breeze Fan RF Remote (FCC ID A25-TX025). "Breeze" mode is configured as oscillate as it is a toggleable fan mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My original issue incorrectly listed Hamilton Bay as the fan manufacturer while it should have been Harbor Breeze (Lowe's in-house brand)
I also added the supported model as the FCC ID of the remote.
#256
I also added in 1081.json, which is another fan from same manufacturer but with a different RF remote / receiver unit. "Breeze" mode is implemented as oscillate, as it is a toggleable mode.
Documentation was also updated as well.