Added option for keeping print conversion active. #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some tags, disabling print conversion (as was the default before) would not make much sense. For example, if print conversion is deactivated, the value of the Composite:LensID tag could be reported as something like "8D 44 5C 8E 34 3C 8F 0E". It is doubtful whether this is useful here, as we would then need to look up what this means in a table supplied with exiftool. We would probably like the human-readable value, which is in this case "AF-S DX Zoom-Nikkor 18-70mm f/3.5-4.5G IF-ED". Disabling print conversion makes sense for a lot of tags (e.g., it's nicer to get as the exposure time not the string "1/2" but the number 0.5). In such cases, even if we enable print conversion, we can disable it for individual tags by appending a # symbol to the tag name.
sylikc
added a commit
to sylikc/pyexiftool
that referenced
this pull request
Jul 18, 2019
tguilday
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some tags, disabling print conversion (as was the default before)
would not make much sense. For example, if print conversion is
deactivated, the value of the Composite:LensID tag could be reported as
something like "8D 44 5C 8E 34 3C 8F 0E". It is doubtful whether this is
useful here, as we would then need to look up what this means in a table
supplied with exiftool. We would probably like the human-readable value,
which is in this case "AF-S DX Zoom-Nikkor 18-70mm f/3.5-4.5G IF-ED".
Disabling print conversion makes sense for a lot of tags (e.g., it's
nicer to get as the exposure time not the string "1/2" but the number
0.5). In such cases, even if we enable print conversion, we can disable
it for individual tags by appending a # symbol to the tag name.