feat: Use stubtest to verify stub correctness#30
Merged
smarie merged 1 commit intosmarie:mainfrom Jul 6, 2022
Merged
Conversation
last-partizan
commented
Jul 2, 2022
4 tasks
last-partizan
force-pushed
the
22-stubtest
branch
3 times, most recently
from
3d52dc4 to
abc0a47
Compare
last-partizan
commented
Jul 6, 2022
last-partizan
commented
Jul 6, 2022
| - name: Install conda v3.7 | ||
| uses: conda-incubator/setup-miniconda@v2 | ||
| with: | ||
| python-version: '3.10' |
Contributor
Author
There was a problem hiding this comment.
For some reason, stubtest cannot handle try/except imports, so i'm using Python 3.10 here.
Owner
There was a problem hiding this comment.
This is not the version used for the tests, this is the version used to execute nox. So 3.7 should be fine too, but of course any will do
last-partizan
force-pushed
the
22-stubtest
branch
from
abc0a47 to
af1e28c
Compare
Owner
|
Nice PR, thanks a lot @last-partizan ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's my first attempt to add stubgen to verify stub correctness.
Right now it's failing with nox, but works fine if i use it with normal venv.It works!