Operatorの命令ブロックをRubyに変換できるようにしました #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takaokouji
reviewed
Oct 19, 2018
takaokouji
reviewed
Oct 19, 2018
takaokouji
reviewed
Oct 19, 2018
|
@t-kazu レビューしました。お手数ですが、修正をお願いします。 |
t-kazu
force-pushed
the
feature/rubygenerator-for-operator
branch
from
fd49e4c to
c89f3f0
Compare
t-kazu
force-pushed
the
feature/rubygenerator-for-operator
branch
from
c89f3f0 to
3b43e06
Compare
t-kazu
commented
Oct 19, 2018
Collaborator
Author
t-kazu
left a comment
t-kazu
left a comment
There was a problem hiding this comment.
優先順位のことすっかり忘れていました。修正しました。
ご確認お願い致します。
src/lib/ruby-generator/operators.js
Outdated
| }; | ||
|
|
||
| Blockly.Ruby.operator_and = function (block) { | ||
| const operand1 = Blockly.Ruby.valueToCode(block, 'OPERAND1', Blockly.Ruby.ORDER_NONE) || 'false'; |
Collaborator
Author
There was a problem hiding this comment.
何も無い時はfalseの動きだったので、何も無い時はfalseを返すようにしています。
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubyのコード的に ${str1}.include(${str2})? にしましたが、${str1}.contains(${str2})? の方がよろしいでしょうか？