feat: implement leaveGroup functionality for peers #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability for peers to explicitly leave a group, ensuring their membership and temporary status data are cleaned up from the system. Backend: - Added LeaveGroupUseCase for business logic orchestration - Implemented remove_node_from_group (atomic) and delete_peer_data in DynamoDBRepository - Updated AppSync Lambda handler to route the leaveGroup mutation Infrastructure: - Added leaveGroup mutation and LeaveGroupPayload to GraphQL schema - Configured LeaveGroupResolver in CDK stack linked to the Lambda data source Prototype Client: - Added leaveGroup method to MeshClient library - Updated UI with "Leave Group" button and state management - Improved disconnect logic to automatically trigger leaveGroup for members Testing: - Added unit tests for LeaveGroupUseCase - Added E2E integration tests in spec/requests/leave_group_spec.rb - Added mutation fixture for leaveGroup 🤖 Generated with [Gemini Code](https://gemini.google.com/code) Co-Authored-By: Gemini <noreply@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability for peers to explicitly leave a group, ensuring their membership and temporary status data are cleaned up from the system.
Implementation Details
Backend
LeaveGroupUseCasefor business logic orchestration.remove_node_from_group(atomic usingtransact_write_items) anddelete_peer_datainDynamoDBRepository.leaveGroupmutation.Infrastructure
leaveGroupmutation andLeaveGroupPayloadto GraphQL schema.LeaveGroupResolverin CDK stack linked to the Lambda data source.Prototype Client
leaveGroupmethod toMeshClientlibrary.leaveGroupfor members.Test Coverage
Unit Tests
LeaveGroupUseCaseinspec/unit/use_cases/leave_group_spec.rb.Integration Tests
spec/requests/leave_group_spec.rb.🤖 Generated with Gemini Code
Co-Authored-By: Gemini noreply@google.com