fix: check that the previous xref is not the just processed xref#727
Merged
Conversation
k00ni
reviewed
Jul 30, 2024
k00ni
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the PR. This really sound like an edge case. Did you experience anything like that before @j0k3r @GreyWyvern?
At first glance the changes look good. I ran the code locally and it fails without the fix.
Co-authored-by: Konrad Abicht <hi@inspirito.de>
Collaborator
|
Thank you @tkegan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of pull request
About
A customer uploaded several files to my employer's product which cause one of our backend processes using smalot/pdfparser (thanks) to bomb with a fatal out of memory error. I attempted to employ the configuration documented. This did not work. Based on metadata this PDF is a scan made on some copier, pdf version 1.7. I did a bit of tracing the problem and found that memory was exhausted in an infinite loop. It seems the copier adds
Prev 0in the trailing portion of a xref. The proposed change checks for this unique case where previous is the just processed xref and ignores it. This works for my employer's product.Checklist for code / configuration changes
In case you changed the code/configuration, please read each of the following checkboxes as they contain valuable information:
By the way, you don't have to provide a full fledged PDF file to demonstrate a fix. Instead a unit test may be sufficient sometimes,
please have a look at FontTest for example code.
Code changes without any tests are likely to be rejected. If you dont know how to write tests, no problem, tell us upfront and we may add them ourselves or discuss other ways.