Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client compatibility for newer versions PHP >= 7.2, <= 8.1 #32

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

nacholibre
Copy link

@nacholibre nacholibre commented Oct 27, 2022

I've update a project from symfony 4.4 to symfony 5.4 and I've started to get errors like these:

Compile Error: Declaration of Smalot\\Cups\\Transport\\Client::sendRequest(Psr\\Http\\Message\\RequestInterface $request) must be compatible with Psr\\Http\\Client\\ClientInterface::sendRequest(Psr\\Http\\Message\\RequestInterface $request)

Changelog for this PR:

  1. Drop support for php 5.6, 7 and 7.1 - this was needed because newer versions of the packages required new php versions. I figured it's better to support php 8, so I've decided to drop support of these older php versions. Php 7.1 is EOF anyway.
  2. Update package used for testing atoum/atoum
  3. Add travis tests for all of the php versions - 7.2, 7.3, 7.4, 8.0 and 8.1
  4. Add version requirements for packages, because * can cause problems, like the ones we experience with the Compile Error:

@nacholibre nacholibre changed the title Update client compatibility Update client compatibility for newer versions Oct 27, 2022
@nacholibre
Copy link
Author

@smalot This is ready for review, not sure why the travis CI build doesn't appear here, but in my fork - it's passing - https://github.com/nacholibre/cups-ipp/runs/9135650354

Thanks

@ro0NL
Copy link

ro0NL commented Dec 7, 2022

ping @smalot

@ro0NL
Copy link

ro0NL commented Dec 8, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants