Fix: Ensure step ca rekey --daemon generates new keys as expected #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of feature:
Rekeying with new private key in daemon mode
Description
This PR fixes #1343 where
step ca rekeywith the--daemonflag was not generating new keys on renewal — behaving like step ca renew instead.Pain or issue this feature alleviates:
Previously, running
step ca rekey ... --daemonwould renew the certificate without generating a new key, defeating the purpose of rekeying. This fixes that behavior.Why is this important to the project (if not answered above):
It ensures rekeying in daemon mode actually rotates the private key, aligning with user expectations and the behavior of one-shot rekeying.
Is there documentation on how to use this feature? If so, where?
Yes
In what environments or workflows is this feature supported?
In what environments or workflows is this feature explicitly NOT supported (if any)?
Supporting links/other PRs/issues:
Fixes: #1343
💔Thank you!