Fallback validation should blow up if the fallback method isn't from … #123
Conversation
…same class, super class or implemented interface.
|
|
||
| // gather all interface methods based on declaring class | ||
| Set<String> allInterfaceMethodNames = new HashSet<>(); | ||
| for (Class<?> clazz : declaringClass.getInterfaces()) { |
There was a problem hiding this comment.
Should this perhaps include super-interfaces of declaringClass.getInterfaces()?
There was a problem hiding this comment.
I don't think spec allows that. Quoting:
The named fallback method must be on the same class, a superclass or an implemented interface of the class which declares the annotated method
From implemented interface of the class... I assume it has to be on an interface that directly implemented by given class.
There was a problem hiding this comment.
I guess that's probably yet another vague formulation in the spec, but fair enough.
There was a problem hiding this comment.
Could be the case, to be fair I am learning about FT spec "on the fly" so take what I say with a pinch of salt ;)
|
Otherwise looking good. |
…same class, super class or implemented interface.
Fixes #122
The tests for this are the TCKs alone because with changes merged in microprofile/microprofile-fault-tolerance#455, smallrye now fails the test in question.