Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check duplicate keys for yaml (snakeyaml.version update to 2.4) #1318

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

fugerit79
Copy link
Contributor

@fugerit79 fugerit79 commented Feb 15, 2025

Hello, first of all thanks for your great work on SmallRye project 😊

With pull request check duplicate keys #1270 I was only able to detect duplicate key in property configuration.

So I worked on SnakeYAML Project and opened a pull request to check duplicate keys in yaml.

This contribution was added in SnakeYAML 2.4.

Basically I propose to :

  • update SnakeYAML version to 2.4
  • add testing for yaml duplication check (just capture and check logging)

What do you think @radcortez ? is it acceptable?

Thanks in advance.

@radcortez
Copy link
Member

Sure. Thank you for the PR.

@radcortez radcortez merged commit e15af82 into smallrye:main Feb 17, 2025
6 checks passed
@github-actions github-actions bot added this to the 3.12.1 milestone Feb 17, 2025
@fugerit79 fugerit79 deleted the 1-check-duplicate-keys-yaml branch February 17, 2025 17:50
@fugerit79
Copy link
Contributor Author

Thank to you! I hope someday it will downstream to Quarkus 😊

PS: actually the inspiration for this PR came from an real issue had on one application.

@radcortez
Copy link
Member

Actually, it is already there: quarkusio/quarkus#46323

@fugerit79
Copy link
Contributor Author

Great! Thanks for the information :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] check duplicate keys
2 participants