Builtin Converters for File and URI
#1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
radcortez
reviewed
Jan 7, 2025
implementation/src/main/java/io/smallrye/config/Converters.java
Outdated
Show resolved
Hide resolved
It seems counter productive to throw so many NoSuchMethodExceptions for these common uses cases.
radcortez
force-pushed
the
default-path-for-jdk-types
branch
from
d0478b2 to
12f756e
Compare
radcortez
approved these changes
Jan 10, 2025
gsmet
commented
Jan 10, 2025
radcortez
changed the title
File and URI
radcortez
changed the title
File and URIFile and URI
|
No worries, I wanted to do the release today, so we have time to fix any issues before the Quarkus release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems counter productive to throw so many NoSuchMethodExceptions for these common uses cases.
These are the ones I could identify in the flame graph, let me know if you see more.