This repository was archived by the owner on Feb 28, 2025. It is now read-only.
WIP: Patch impovements #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/__tests__/PinMessages.test.tsx src/components/Callout/Callout.tsx Changes to be committed: modified: package-lock.json modified: package.json modified: src/__fixtures__/chat.ts modified: src/__fixtures__/chat_config_thread.ts modified: src/__fixtures__/chat_links_response.ts modified: src/__fixtures__/history.ts modified: src/__fixtures__/msw.ts modified: src/__fixtures__/some_chrome_screenshots.ts modified: src/__tests__/DeleteChat.test.tsx modified: src/__tests__/RestoreChat.test.tsx modified: src/components/Callout/Callout.tsx modified: src/components/Chat/Chat.stories.tsx modified: src/components/Chat/Chat.tsx modified: src/components/ChatContent/ChatContent.stories.tsx modified: src/components/ChatForm/ChatControls.tsx modified: src/components/ChatForm/ChatForm.tsx new file: src/components/ChatForm/SuggestNewChat/SuggestNewChat.module.css new file: src/components/ChatForm/SuggestNewChat/SuggestNewChat.tsx new file: src/components/ChatForm/SuggestNewChat/index.ts modified: src/components/IntegrationsView/DisplayIntegrations/IntegrationCard.module.css modified: src/components/IntegrationsView/DisplayIntegrations/IntegrationCard.tsx new file: src/components/IntegrationsView/DisplayIntegrations/useUpdateIntegration.ts modified: src/components/IntegrationsView/IntegrationsView.tsx modified: src/components/IntegrationsView/hooks/useIntegrations.ts modified: src/features/Chat/Thread/actions.ts modified: src/features/Chat/Thread/reducer.ts modified: src/features/Chat/Thread/selectors.ts modified: src/features/Chat/Thread/types.ts modified: src/hooks/useCapsForToolUse.ts modified: src/hooks/useLinksFromLsp.ts modified: src/services/refact/links.ts
alashchev17
suggested changes
Feb 17, 2025
src/components/Callout/Callout.tsx
Outdated
|
|
||
| const handleRetryClick = () => { | ||
| // TBD: why was this added? | ||
| // if (preventRetry) return; |
Member
There was a problem hiding this comment.
This was added in PR for special callouts on 401 errors, when I needed to prevent closing of callout to make them request help or re-login.
But though this functionality now doesn't work, just because LSP still returns 500 codes
src/components/Tools/Textdoc.tsx
Outdated
Comment on lines
97
to
103
| "error" in results && | ||
| typeof results.error === "object" && | ||
| "data" in results.error && | ||
| results.error.data && | ||
| typeof results.error.data === "object" && | ||
| "detail" in results.error.data && | ||
| typeof results.error.data.detail === "string" |
Member
There was a problem hiding this comment.
Couldn't all of these checks live in local and near-living typeguard functions?
src/components/Tools/Textdoc.tsx
Outdated
| )} | ||
| </Flex> | ||
| {errorMessage && ( | ||
| <ErrorCallout onClick={clearErrorMessage} timeout={5000} preventRetry> |
Member
There was a problem hiding this comment.
Please, uncomment in Callout.tsx preventRetry property, we might need to come up with better naming to avoid commenting it out in the future :D
Contributor
Author
There was a problem hiding this comment.
Okay I'll need to change the order of checking preventRetry and closing the error message.
Member
|
It looks nice, though a few comments left |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch improvements
Description
📍 notation has been removed, patches are now down in tool messages. This PR removed the code for the pin messages and uses a dedicated ui for the tool if it's a
textdoctype tool.Type of change
How to Test
devbrnch of the lspnew-patch-functionsbranch of refact-vscodeScreenshots (if applicable)
Checklist
Linked Issues
Additional Notes